From b1f5ad55b8f894560ea27c7ffdbe84a45fb35b5c Mon Sep 17 00:00:00 2001
From: YunaiV <zhijiantianya@gmail.com>
Date: Sun, 19 Nov 2023 00:28:22 +0800
Subject: [PATCH] =?UTF-8?q?crm=EF=BC=9Acode=20review=20=E6=9D=83=E9=99=90?=
 =?UTF-8?q?=E5=88=97=E8=A1=A8?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/api/crm/permission/index.ts                |  4 ++--
 src/views/crm/components/CrmPermissionForm.vue |  3 +++
 src/views/crm/components/CrmTeamList.vue       | 15 ++++++++++++---
 src/views/crm/customer/index.vue               |  4 ++--
 4 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/src/api/crm/permission/index.ts b/src/api/crm/permission/index.ts
index e790c334..1292f29a 100644
--- a/src/api/crm/permission/index.ts
+++ b/src/api/crm/permission/index.ts
@@ -6,9 +6,9 @@ export interface PermissionVO {
   bizType: number | undefined // Crm 类型
   bizId: number | undefined // Crm 类型数据编号
   level: number | undefined // 权限级别
-  deptName?: string // 部门名称
+  deptName?: string // 部门名称 // 岗位名称数组 TODO @puhui999：数组？
   nickname?: string // 用户昵称
-  postNames?: string // 岗位名称数组
+  postNames?: string // 岗位名称数组 TODO @puhui999：数组？
   createTime?: Date
 }
 
diff --git a/src/views/crm/components/CrmPermissionForm.vue b/src/views/crm/components/CrmPermissionForm.vue
index 9754637b..838aa68d 100644
--- a/src/views/crm/components/CrmPermissionForm.vue
+++ b/src/views/crm/components/CrmPermissionForm.vue
@@ -19,6 +19,7 @@
       </el-form-item>
       <el-form-item label="权限级别" prop="level">
         <el-radio-group v-model="formData.level">
+          <!-- TODO @puhui999：搞个字典配置？然后这里 remove 掉负责人 -->
           <el-radio :label="CrmPermissionLevelEnum.READ">只读</el-radio>
           <el-radio :label="CrmPermissionLevelEnum.WRITE">读写</el-radio>
         </el-radio-group>
@@ -36,6 +37,7 @@ import * as PermissionApi from '@/api/crm/permission'
 import { CrmPermissionLevelEnum } from './index'
 
 defineOptions({ name: 'CrmPermissionForm' })
+
 const { t } = useI18n() // 国际化
 const message = useMessage() // 消息弹窗
 
@@ -107,6 +109,7 @@ const resetForm = (bizType: number, bizId: number) => {
 }
 onMounted(async () => {
   // 获得用户列表
+  // TODO 芋艿：用户列表的选择组件
   userOptions.value = await UserApi.getSimpleUserList()
 })
 </script>
diff --git a/src/views/crm/components/CrmTeamList.vue b/src/views/crm/components/CrmTeamList.vue
index f7591f6a..568777f6 100644
--- a/src/views/crm/components/CrmTeamList.vue
+++ b/src/views/crm/components/CrmTeamList.vue
@@ -38,6 +38,7 @@
   <CrmPermissionForm ref="crmPermissionFormRef" />
 </template>
 <script lang="ts" setup>
+// TODO @puhui999：改成 CrmPermissionList
 import { dateFormatter } from '@/utils/formatTime'
 import { ElTable } from 'element-plus'
 import * as PermissionApi from '@/api/crm/permission'
@@ -46,6 +47,9 @@ import CrmPermissionForm from './CrmPermissionForm.vue'
 import { CrmPermissionLevelEnum } from './index'
 
 defineOptions({ name: 'CrmTeam' })
+
+const message = useMessage() // 消息
+
 const props = defineProps<{
   bizType: number
   bizId: number
@@ -65,18 +69,22 @@ const list = ref<PermissionApi.PermissionVO[]>([
     createTime: new Date()
   }
 ]) // 列表的数据
+
+/** 查询列表 */
 const getList = async () => {
   loading.value = true
   try {
-    const res = await PermissionApi.getPermissionList({
+    const data = await PermissionApi.getPermissionList({
       bizType: props.bizType,
       bizId: props.bizId
     })
-    list.value = res
+    list.value = data
   } finally {
     loading.value = false
   }
 }
+
+// TODO @puhui999：字典格式化
 /**
  * 获得权限级别名称
  * @param level 权限级别
@@ -93,11 +101,12 @@ const getLevelName = computed(() => (level: number) => {
       break
   }
 })
+// TODO @puhui999：空行稍微注意下哈；一些注释补齐下；
 const multipleSelection = ref<PermissionApi.PermissionVO[]>([])
 const handleSelectionChange = (val: PermissionApi.PermissionVO[]) => {
   multipleSelection.value = val
 }
-const message = useMessage()
+// TODO @puhui999：一些变量命名，看看有没可能跟列表界面的 index.vue 保持他统一的风格；
 const crmPermissionFormRef = ref<InstanceType<typeof CrmPermissionForm>>()
 const handleEdit = () => {
   if (multipleSelection.value?.length === 0) {
diff --git a/src/views/crm/customer/index.vue b/src/views/crm/customer/index.vue
index b214d7c1..dea7e617 100644
--- a/src/views/crm/customer/index.vue
+++ b/src/views/crm/customer/index.vue
@@ -185,8 +185,8 @@
       @pagination="getList"
     />
   </ContentWrap>
-  <!-- TODO 方便查看效果 -->
-  <CrmTeam :biz-id="1" :biz-type="CrmBizTypeEnum.CRM_CUSTOMER" />
+  <!-- TODO 方便查看效果 TODO 芋艿：先注释了，避免演示环境报错 -->
+  <!--  <CrmTeam :biz-id="1" :biz-type="CrmBizTypeEnum.CRM_CUSTOMER" />-->
 
   <!-- 表单弹窗：添加/修改 -->
   <CustomerForm ref="formRef" @success="getList" />